You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
>>> assets = kili.assets(project_id=project_id, step_status_in=['TO_DO'])
UserWarning: Field status requested : request fields step and stepStatus instead for this project
-> we should not pass status by default in fields if the project is in workflow V2, to avoid a warning if user does not specify fields explicitly
-> I think we should add a validator on step_in to only allow valid values, and raise if the step name is invalid (like for step_status_in)
-> Suggestion : rename step_in to step_name_in ? At first, I thought it was step ids - might be confusing for user
-> Should not the step name be Label and Review 1 ? (as you're currently refactoring it, I don't know if it's need to be in this MR)
>>> assets = kili.assets(project_id=project_id, step_status_in=['DOING'])
>>> print(len(assets))
1
>>> assets = kili.assets(project_id=project_id, status_in=['ONGOING'])
>>> print(len(assets))
UserWarning: Field status requested : request fields step and stepStatus instead for this project
0
-> I think it would be better to raise if user request fields forbidden in workflow V2 (and vice-versa) to avoid incorrect results
>>> assets = kili.assets(project_id=project_id, step_status_in=['SKIPPED'], skipped=True)
>>> print(len(assets))
UserWarning: Filter skipped given : use filter step_status_in with the SKIPPED status instead for this project
1
>>> assets = kili.assets(project_id=project_id, skipped=True)
>>> print(len(assets))
1
-> I think this user warning should be present even if the user did not specify step_status_in
"not pass status by default in fields" : not resolved here. We will not modify this because the default project are not workflowV2 yet. When it will be the case, we can modify accordingly.
"validator on step_in" : added a validation on step names
"rename step_in to step_name_in" : renamed accordingly
"Should not the step name be Label and Review 1" : this is not addressed here : ticket Lab-3565 does the trick.
"I think it would be better to raise if user request fields forbidden in workflow V2 (and vice-versa) to avoid incorrect results" : there are a few cases. In some cases, we trigger a warning, in other we trigger errors (as identified on the ticket)
"I think this user warning should be present even if the user did not specify step_status_in" : added a verification in this case
"I would move step_in and step_status_in just below status_in, to enhance documentation readability" : moved sections closer to each other
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.